simple-mpv-webui icon indicating copy to clipboard operation
simple-mpv-webui copied to clipboard

[RFC] switch fontawesome to git submodule

Open vapier opened this issue 4 years ago • 5 comments

Not sure how you feel about gitsubmodules, but it makes it easier to update.

vapier avatar Jan 04 '21 15:01 vapier

if you'd rather not use gitsubmodules, i totally understand. on a related note, the current fonts are outdated :).

vapier avatar Jan 04 '21 15:01 vapier

Sorry for the accidental close/reopen.

Thanks for the PR :tada:. I'm also not sure how I feel about submodules, never used them a lot :). But I guess it's the way to go.

Could you please also extend the README in regard to this change? And the checkout action might need a submodules: 'true'.

open-dynaMIX avatar Jan 04 '21 16:01 open-dynaMIX

@vapier I'd like to bring this PR into master. Are you gonna continue working on it, or should I finish it?

open-dynaMIX avatar Feb 13 '21 15:02 open-dynaMIX

i prob won't get back to this anytime soon as i'm not currently using mpv :)

feel free to finish it up or just close

vapier avatar Mar 05 '22 19:03 vapier

Alright, thanks for letting me know!

open-dynaMIX avatar Mar 06 '22 07:03 open-dynaMIX