open-dis-java icon indicating copy to clipboard operation
open-dis-java copied to clipboard

Unmarshaling enters infinite loop if the length field is zero.

Open kastork opened this issue 5 years ago • 4 comments

When sending PDU's constructed in open-dis python, the length field is zero. During unmarshalling in open-dis-java, an infinite loop is entered because the buffer read pointer is never advanced to the end of the first pdu in the UDP packet.

A pdu with zero in the length field should be detected as invalid and handled accordingly.

kastork avatar Mar 30 '20 19:03 kastork

Thank-you for the report @kastork . That's a great test case that uses the different language implementations.

Would you be interested in submitting a pull request to fix this?

leif81 avatar Apr 01 '20 02:04 leif81

Yes, could be a while though.

kastork avatar Apr 09 '20 14:04 kastork