condo fix(condo): DOMA-11613 fix logic open filter modal

Summary by CodeRabbit

Bug Fixes
- Improved filter template comparison by ignoring empty and nil fields, ensuring more accurate matching.
- Enhanced state handling for filter templates to consistently use null when a template is not found.
- Refined initial form values logic for filters, providing better handling when templates or fields are missing.
- Fixed filter reset behavior to ensure proper asynchronous handling and consistent filter clearing.

May 15 '25 10:05 tolmachev21

"""

Walkthrough

The code modifies the ResetFiltersModalButton to await asynchronous router replacement before resetting filters, explicitly sets openedFiltersTemplate to null when no matching template is found on tab change, refines filter value cleaning logic by omitting empty values, and revises initial form values computation in the modal to consider multiple fallback cases.

Changes

File Change Summary

apps/condo/domains/common/hooks/useMultipleFiltersModal.tsx Made handleReset await asynchronous router replacement; updated equality check to omit empty values (not just nil); omitted empty values before saving filters; explicitly set openedFiltersTemplate to null if no matching template; updated initial form values logic to fallback from openedFiltersTemplate?.fields to empty object or current filters; simplified modal form render function; updated modal footer dependencies.

File	Change Summary
apps/condo/domains/common/hooks/useMultipleFiltersModal.tsx	Made `handleReset` await asynchronous router replacement; updated equality check to omit empty values (not just `nil`); omitted empty values before saving filters; explicitly set `openedFiltersTemplate` to `null` if no matching template; updated initial form values logic to fallback from `openedFiltersTemplate?.fields` to empty object or current filters; simplified modal form render function; updated modal footer dependencies.

Poem

🐇 Hopping through filters, neat and bright,
Awaiting routes before reset takes flight.
Nulls replace the shadows where templates hide,
Forms now gather fields with care and pride.
In code’s soft meadow, changes bloom just right! 🌸✨ """

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 6655f28c88105b8f4e76c28a5599b9390173c676 and 75768e8261b468e5ddaf055e6bd4870a6552d4b0.

📒 Files selected for processing (1)

apps/condo/domains/common/hooks/useMultipleFiltersModal.tsx (7 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/condo/domains/common/hooks/useMultipleFiltersModal.tsx

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Build open-source part (ubuntu-22.04, 16.x, 3.13)
GitHub Check: Build open-source part (windows-latest, 16.x, 3.13)
GitHub Check: Semgrep vulnerabilities check
GitHub Check: Check dependencies integrity (16.x)
GitHub Check: Lint source code (16.x)
GitHub Check: Build Docker Image

✨ Finishing Touches

[ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json