condo fix(condo): DOMA-11329 update read function in cache (proof of concept)

If you load a page from the second and so on, when skip > 0 is specified in the request, then the request to the sheet for the skipped elements will grow empty values. If you then go back to the page, then an empty list will be returned (that is, there will be no request for data before the sheet that we previously requested)

Summary by CodeRabbit

Refactor
- Enhanced the list merging process to improve filtering by excluding empty or invalid entries, ensuring only valid data is processed and returned.

Mar 26 '25 13:03 tolmachev21

Walkthrough

This change introduces a new type, EmptyData, which represents an object with an empty property set to true. The mergeLists method's return type now includes this type alongside TData and null. The internal filtering logic in the _readPage and _readAll methods has been updated to remove items that are either null or of type EmptyData. Variable names have been improved for clarity, ensuring that only valid items are returned after filtering.

Changes

File	Change Summary
packages/apollo/.../lists.ts	Introduced `EmptyData` type. Updated `mergeLists` to return `Array<TData

Sequence Diagram(s)

sequenceDiagram
    participant Client as Caller
    participant Processor as List Handler
    participant Filter as Filtering Logic

    Client->>Processor: Invoke list processing (_readPage/_readAll)
    Processor->>Filter: Pass raw list items for filtering
    Filter->>Filter: Check items for null or EmptyData
    Filter-->>Processor: Return filtered valid items
    Processor-->>Client: Return final list of valid items

Poem

Oh what a hop, I must exclaim,
New type and filters, not just a game.
I sculpted code with care and light,
Filtering out what's not shining bright.
From null to empty, I now display,
A tidy list, come join my play! 🐇✨

✨ Finishing Touches

[ ] 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json