condo icon indicating copy to clipboard operation
condo copied to clipboard

feat(condo): added translation of the platform into Spanish

Open paulo-rossy opened this issue 1 year ago • 3 comments

paulo-rossy avatar Jun 11 '24 09:06 paulo-rossy

Hi, thanks for your contribution! We are near to fix issue with fork tests running. So we will get back to you with an update soon

Hello! Is there any progress on my pull requests?

paulo-rossy avatar Jul 25 '24 11:07 paulo-rossy

We need to implement fallback logic for translations to ensure that all necessary keys are included. Could you resolve the conflicts?

Once that's done, we can proceed to integrate the fallback logic, which will utilize the default locale and the current language to generate a unified translation. With this approach, we can confidently push these changes.

pahaz avatar Nov 07 '24 20:11 pahaz

Hi! I want to help you to move it to our main branch. It looks like we need to update our checklist:

  • [x] fix migration check: https://github.com/open-condo-software/condo/pull/5476
  • [x] fix locale linter to avoid required es keys
  • [x] add fallback logic for non default locales to use default locale translation if translation key doesn't exists

pahaz avatar Nov 12 '24 15:11 pahaz

So I'll move the work related to this PR to https://github.com/open-condo-software/condo/issues/5514 and https://github.com/open-condo-software/condo/pull/5515

pahaz avatar Nov 20 '24 15:11 pahaz

merged: https://github.com/open-condo-software/condo/pull/5515 Thanks for contribution!

pahaz avatar Nov 21 '24 19:11 pahaz