PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

shift from tolerance for `thd` to tolerance for `RH` in the diffusional growth adaptivity scheme

Open abulenok opened this issue 3 years ago • 8 comments

abulenok avatar Jul 08 '22 10:07 abulenok

Stale pull request message

github-actions[bot] avatar Sep 08 '22 13:09 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Nov 08 '22 14:11 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Jan 08 '23 13:01 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Mar 10 '23 13:03 github-actions[bot]

Looking at what causes the failures, it seems that we have to simultaneously address #411 and #334 here

slayoo avatar Jun 07 '23 23:06 slayoo

Stale pull request message

github-actions[bot] avatar Aug 07 '23 13:08 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Oct 23 '23 13:10 github-actions[bot]

The original reason for the change proposed here was the unstable behavior of the condensation solver in parcel simulations. In the meantime, this was also addressed in #746. Switching from thd to RH as the tolerance control variable is likely still a good idea, but since we were not able to renorm the tests robustly, it seems that it comes with some tradeoffs. Closing for now.

slayoo avatar Dec 08 '23 07:12 slayoo

this is now part of #1681

slayoo avatar Jul 21 '25 16:07 slayoo