PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

draft of atomic_min in adaptive_sdm_gamma

Open piotrbartman opened this issue 4 years ago • 13 comments

atomic_min does not work with floating points, so something like that is necessary. It's hacky, but on the other hand it should work since high precision is not crucial here.

addressed in #571

piotrbartman avatar Jun 21 '21 21:06 piotrbartman

worth to note, on 32-bit Appveyor it failed with:

        # Act
        backend.adaptive_sdm_gamma(_gamma, _n, _cell_id, _dt_left, dt, dt_range, _is_first_in_pair, _n_substep, _dt_min)
    
        # Assert
>       np.testing.assert_array_almost_equal(_dt_left.to_ndarray(), np.asarray(expected_dt_left))
E       AssertionError: 
E       Arrays are not almost equal to 6 decimals
E       
E       Mismatched elements: 1 / 2 (50%)
E       Max absolute difference: 5.
E       Max relative difference: 1.
E        x: array([0., 0.])
E        y: array([0., 5.])
PySDM_tests\unit_tests\backends\test_algorithmic_methods.py:76: AssertionError

slayoo avatar Sep 17 '21 04:09 slayoo

Stale pull request message

github-actions[bot] avatar Nov 16 '21 13:11 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Jan 16 '22 13:01 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Mar 18 '22 13:03 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Aug 03 '22 13:08 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Oct 03 '22 14:10 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Dec 03 '22 13:12 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Feb 02 '23 13:02 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Apr 07 '23 13:04 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Jun 08 '23 14:06 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Aug 08 '23 13:08 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Oct 15 '23 13:10 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Dec 22 '23 13:12 github-actions[bot]