PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

refactor moments so that histograms are done with one invocation (and check for spurious allocations in products)

Open slayoo opened this issue 5 years ago • 16 comments

slayoo avatar Sep 21 '20 06:09 slayoo

As of now, moments_body takes almost 30% of cpu time in Yang example based smoke tests (e.g., test_just_do_it) with call counts of hundreds of thousands... while in principle all what is done could be completed in one (parallel, see #401) pass over particles per output step.

slayoo avatar Apr 22 '21 12:04 slayoo

Stale issue message

github-actions[bot] avatar Sep 18 '21 13:09 github-actions[bot]

keep open, this is a few-LoC/high-impact candidate!

slayoo avatar Sep 18 '21 19:09 slayoo

Stale issue message

github-actions[bot] avatar Dec 22 '21 13:12 github-actions[bot]

Stale issue message

github-actions[bot] avatar Feb 24 '22 13:02 github-actions[bot]

Stale issue message

github-actions[bot] avatar Apr 26 '22 13:04 github-actions[bot]

Stale issue message

github-actions[bot] avatar Jun 26 '22 13:06 github-actions[bot]

Stale issue message

github-actions[bot] avatar Aug 26 '22 14:08 github-actions[bot]

Stale issue message

github-actions[bot] avatar Oct 26 '22 14:10 github-actions[bot]

we've just profile a few 0D, 1D and 2D examples with @mstach60161 and this seem not to be an issue anymore! (likely thanks to moments refactors and added multi-threading done earlier by @piotrbartman) There are a few TODO labels in the code for this issue, so not closing yet, but soon to be closed.

slayoo avatar Dec 09 '22 10:12 slayoo

Stale issue message

github-actions[bot] avatar Feb 07 '23 13:02 github-actions[bot]

Stale issue message

github-actions[bot] avatar Apr 11 '23 13:04 github-actions[bot]

Stale issue message

github-actions[bot] avatar Jun 12 '23 13:06 github-actions[bot]

Stale issue message

github-actions[bot] avatar Aug 19 '23 14:08 github-actions[bot]

Stale issue message

github-actions[bot] avatar Oct 26 '23 14:10 github-actions[bot]

Stale issue message

github-actions[bot] avatar Jan 11 '24 15:01 github-actions[bot]