PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

liquid-water-content: avoid misleading var name

Open slayoo opened this issue 4 months ago • 4 comments

slayoo avatar Oct 20 '25 16:10 slayoo

CC @yoctoyotta1024

slayoo avatar Oct 20 '25 16:10 slayoo

same here: https://github.com/open-atmos/PySDM/blob/73ccc3d24c62b67bce13565eb181bcef7d1ba3d2/PySDM/products/size_spectral/water_mixing_ratio.py#L34

slayoo avatar Oct 20 '25 16:10 slayoo

Codecov Report

:x: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 86.50%. Comparing base (d5320fe) to head (ac6f423). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...roducts/aqueous_chemistry/aqueous_mole_fraction.py 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1730   +/-   ##
=======================================
  Coverage   86.50%   86.50%           
=======================================
  Files         412      412           
  Lines       10372    10372           
=======================================
  Hits         8972     8972           
  Misses       1400     1400           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 20 '25 16:10 codecov[bot]

CC @yoctoyotta1024

looks good to me! :)

yoctoyotta1024 avatar Oct 27 '25 09:10 yoctoyotta1024