super-droplet attribute "alpha" sampling (incl. new example based on Fig 1 from Matsushima et al. 2023)
- [ ] ConstantMultiplicity is only approximately constant currently
- [ ] tf tests have high tolerances for CM...
- [ ] The figure looks a little off, potentially it is the aerosol distribution and not the sampling?
closing as it is now part of #1687
@emmacware, reopened this PR to separate the alpha-sampling changes from the Hill & Shipway PR (#1687).
Thus, removed any changes to the H&S example from this PR.
The remaining notebook here is the Matsushima et al. fig 1. However, it looks pretty different from the paper - is it intentional?
this PR:
paper:
It would be great to add a smoke test asserting on the features of this plot.
@emmacware, please push here the fix removing the "wiggle" - let's try to merge it! Thanks
Codecov Report
:x: Patch coverage is 89.85507% with 7 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 86.62%. Comparing base (a14c605) to head (a18c137).
:warning: Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
+ Coverage 86.55% 86.62% +0.06%
==========================================
Files 413 413
Lines 10455 10471 +16
==========================================
+ Hits 9049 9070 +21
+ Misses 1406 1401 -5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
thank you @emmacware !