PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

super-droplet attribute "alpha" sampling (incl. new example based on Fig 1 from Matsushima et al. 2023)

Open emmacware opened this issue 8 months ago • 5 comments

emmacware avatar Jun 16 '25 13:06 emmacware

  • [ ] ConstantMultiplicity is only approximately constant currently
  • [ ] tf tests have high tolerances for CM...
  • [ ] The figure looks a little off, potentially it is the aerosol distribution and not the sampling?

emmacware avatar Jun 20 '25 17:06 emmacware

closing as it is now part of #1687

slayoo avatar Jul 23 '25 16:07 slayoo

@emmacware, reopened this PR to separate the alpha-sampling changes from the Hill & Shipway PR (#1687). Thus, removed any changes to the H&S example from this PR. The remaining notebook here is the Matsushima et al. fig 1. However, it looks pretty different from the paper - is it intentional? this PR: image paper: image It would be great to add a smoke test asserting on the features of this plot.

slayoo avatar Sep 17 '25 13:09 slayoo

@emmacware, please push here the fix removing the "wiggle" - let's try to merge it! Thanks

slayoo avatar Oct 16 '25 19:10 slayoo

Codecov Report

:x: Patch coverage is 89.85507% with 7 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 86.62%. Comparing base (a14c605) to head (a18c137). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
PySDM/initialisation/sampling/spectral_sampling.py 93.44% 4 Missing :warning:
PySDM/environments/kinematic_1d.py 0.00% 2 Missing :warning:
PySDM/environments/kinematic_2d.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
+ Coverage   86.55%   86.62%   +0.06%     
==========================================
  Files         413      413              
  Lines       10455    10471      +16     
==========================================
+ Hits         9049     9070      +21     
+ Misses       1406     1401       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 20 '25 05:10 codecov[bot]

thank you @emmacware !

slayoo avatar Nov 24 '25 22:11 slayoo