PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

Added example based on Loftus and Wordsworth 2021 figure 2

Open lursz opened this issue 8 months ago • 5 comments

Added the notebook and utils for recreating figure 2 from Loftus and Wordsworth 2021. The changes:

  • Implemented a comprehensive simulation setup with support for multi-core processing and custom settings,
  • Introduced the AlienParcel class representing the different experimental environments.
  • Added tests for accuracy and consistency for the example.

lursz avatar Jun 10 '25 14:06 lursz

@kaitlyn-loftus, FYI - new example being developed for PySDM - kudos @lursz, @emmacware, @piotrkubala, @Hevagog & @mzsuetam! image

slayoo avatar Jun 10 '25 16:06 slayoo

great news! happy to share any code or try to help out!!

there are also a bunch of functions for properties of a CO2 atmosphere here: https://github.com/kaitlyn-loftus/serious-cirrus/blob/main/src/%CE%9C%CE%A6.jl

kaitlyn-loftus avatar Jun 10 '25 20:06 kaitlyn-loftus

CI fails de to pre-commit being neither installed or run:

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted tests/examples_tests/Loftus_and_Wordsworth_2021/ground_truth/gen_figure.py

All done! ✨ 🍰 ✨
1 file reformatted, 837 files left unchanged.

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
debug statements (python)................................................Passed
check json...............................................................Passed

For help, see: https://github.com/open-atmos/python-dev-hints/wiki/Pre-commit-FAQ

slayoo avatar Jun 18 '25 07:06 slayoo

CI fails de to pre-commit being neither installed or run:

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted tests/examples_tests/Loftus_and_Wordsworth_2021/ground_truth/gen_figure.py

All done! ✨ 🍰 ✨
1 file reformatted, 837 files left unchanged.

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
debug statements (python)................................................Passed
check json...............................................................Passed

For help, see: https://github.com/open-atmos/python-dev-hints/wiki/Pre-commit-FAQ

Fixed.

piotrkubala avatar Jun 23 '25 21:06 piotrkubala

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 85.66%. Comparing base (07512fe) to head (dba682d). :warning: Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1648   +/-   ##
=======================================
  Coverage   85.66%   85.66%           
=======================================
  Files         403      403           
  Lines        9771     9773    +2     
=======================================
+ Hits         8370     8372    +2     
  Misses       1401     1401           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 24 '25 20:06 codecov[bot]