PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

Monte Carlo Method for Displacement Dynamic

Open Bodzio-2 opened this issue 8 months ago • 1 comments

Bodzio-2 avatar Jun 10 '25 13:06 Bodzio-2

CI fails (https://github.com/open-atmos/PySDM/actions/runs/15562732280/job/43825166589?pr=1647) due to pylint-reported issues:

************* Module PySDM.backends.impl_numba.methods.displacement_methods
PySDM/backends/impl_numba/methods/displacement_methods.py:17:0: C0301: Line too long (119/100) (line-too-long)
PySDM/backends/impl_numba/methods/displacement_methods.py:34:0: C0301: Line too long (119/100) (line-too-long)
PySDM/backends/impl_numba/methods/displacement_methods.py:60:0: C0301: Line too long (119/100) (line-too-long)
PySDM/backends/impl_numba/methods/displacement_methods.py:92:0: C0301: Line too long (119/100) (line-too-long)
PySDM/backends/impl_numba/methods/displacement_methods.py:123:0: C0301: Line too long (120/100) (line-too-long)
************* Module PySDM.backends.impl_thrust_rtc.methods.displacement_methods
PySDM/backends/impl_thrust_rtc/methods/displacement_methods.py:105:0: C0301: Line too long (120/100) (line-too-long)
PySDM/backends/impl_thrust_rtc/methods/displacement_methods.py:105:117: W0613: Unused argument 'rng' (unused-argument)
************* Module PySDM.dynamics.displacement
PySDM/dynamics/displacement.py:144:69: C0303: Trailing whitespace (trailing-whitespace)
PySDM/dynamics/displacement.py:127:4: R0913: Too many arguments (6/5) (too-many-arguments)
************* Module PySDM.particulator
PySDM/particulator.py:429:0: C0301: Line too long (110/100) (line-too-long)
************* Module PySDM.physics.particle_advection.explicit_in_space
PySDM/physics/particle_advection/explicit_in_space.py:12:0: C0301: Line too long (282/100) (line-too-long)
PySDM/physics/particle_advection/explicit_in_space.py:11:4: R0913: Too many arguments (7/5) (too-many-arguments)
PySDM/physics/particle_advection/explicit_in_space.py:11:42: W0613: Unused argument 'cell_id' (unused-argument)
************* Module PySDM.physics.particle_advection.implicit_in_space
PySDM/physics/particle_advection/implicit_in_space.py:13:0: C0301: Line too long (302/100) (line-too-long)
PySDM/physics/particle_advection/implicit_in_space.py:11:4: R0913: Too many arguments (7/5) (too-many-arguments)
PySDM/physics/particle_advection/implicit_in_space.py:11:42: W0613: Unused argument 'cell_id' (unused-argument)
************* Module tests.unit_tests.dynamics.displacement.displacement_settings
tests/unit_tests/dynamics/displacement/displacement_settings.py:42:0: C0301: Line too long (125/100) (line-too-long)
************* Module tests.unit_tests.dynamics.displacement.test_monte_carlo
tests/unit_tests/dynamics/displacement/test_monte_carlo.py:161:0: C0303: Trailing whitespace (trailing-whitespace)

-----------------------------------
Your code has been rated at 9.99/10

and due to pre-commit not being run or installed (https://github.com/open-atmos/PySDM/actions/runs/15562732326/job/43825167611?pr=1647):

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted PySDM/backends/impl_numba/methods/displacement_methods.py
reformatted PySDM/backends/impl_thrust_rtc/methods/displacement_methods.py
reformatted PySDM/dynamics/displacement.py
reformatted PySDM/physics/particle_advection/explicit_in_space.py
reformatted PySDM/physics/particle_advection/implicit_in_space.py
reformatted PySDM/particulator.py
reformatted tests/unit_tests/dynamics/displacement/displacement_settings.py
reformatted tests/unit_tests/dynamics/displacement/test_advection.py
reformatted tests/unit_tests/dynamics/displacement/test_monte_carlo.py

All done! ✨ 🍰 ✨
9 files reformatted, 819 files left unchanged.

For pre-commit help see e.g. https://github.com/open-atmos/python-dev-hints/wiki/Pre-commit-FAQ

slayoo avatar Jun 18 '25 06:06 slayoo