PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

fix support for breakup in 2D kinematic env example

Open slayoo opened this issue 1 year ago • 2 comments

it's a regression introduced in #1371 which was not caught by CI due to lack of test coverage will break in: https://github.com/open-atmos/PySDM/blob/main/examples/PySDM_examples/Szumowski_et_al_1998/simulation.py#L115-L116

slayoo avatar Nov 24 '24 23:11 slayoo

Should we add separate settings file for this example?

AgnieszkaZaba avatar Nov 25 '24 07:11 AgnieszkaZaba

Yes, I'd say we could try to move the GUI logic out of the Arabas_et_al_2015 example as it has little relevance to the paper.

It would be best to provide a non-GUI notebook in this example that reproduces results close to the paper (i.e., the new settings file), while moving the GUI elsewhere (perhaps to tutorials?) and equipping it with tests covering all conditional cases.

slayoo avatar Nov 25 '24 09:11 slayoo