PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

Update comparison data format for dJ/Azimi example

Open ekdejong opened this issue 1 year ago • 3 comments

Updates the jupyter notebooks to use netcdf file output (generated from Cloudy.jl) rather than a python script.

ekdejong avatar Jun 14 '24 21:06 ekdejong

@edejong-caltech the box.ipynb notebook has been commited with some errors in the output, hence devops_tests complain:

FAILED tests/devops_tests/test_notebooks.py::test_no_errors_or_warnings_in_output[examples/PySDM_examples/deJong_Azimi/box.ipynb] - AssertionError: /Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/python3.9/site-packages/xarray/backends/plugins.py:65: RuntimeWarning: Engine 'rasterio' loading failed:
dlopen(/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/python3.9/site-packages/rasterio/_base.cpython-39-darwin.so, 0x0002): Library not loaded: @rpath/libpoppler.91.dylib
  Referenced from: <0B63E196-8B06-333E-89EA-5BB2851BB4E2> /Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libgdal.26.dylib
  Reason: tried: '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/python3.9/site-packages/rasterio/../../../libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/python3.9/site-packages/rasterio/../../../libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/bin/../lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/bin/../lib/libpoppler.91.dylib' (no such file), '/usr/local/lib/libpoppler.91.dylib' (no such file), '/usr/lib/libpoppler.91.dylib' (no such file, not in dyld cache)
  warnings.warn(f"Engine {name!r} loading failed:\n{ex}", RuntimeWarning)

Also, there are some pylint errors from test_box.py:


tests/smoke_tests/box/dejong_azimi/test_box.py:47:21: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:49:12: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:50:14: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:81:21: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:83:12: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:84:14: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)

slayoo avatar Jun 15 '24 13:06 slayoo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.66%. Comparing base (1a15de0) to head (1d00ea0). Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
- Coverage   83.66%   83.66%   -0.01%     
==========================================
  Files         364      364              
  Lines        8939     8938       -1     
==========================================
- Hits         7479     7478       -1     
  Misses       1460     1460              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Jun 15 '24 14:06 codecov[bot]

Stale pull request message

github-actions[bot] avatar Sep 14 '24 13:09 github-actions[bot]