PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

Jensen & Nugent example TODOs

Open slayoo opened this issue 2 years ago • 4 comments

slayoo avatar Feb 07 '24 08:02 slayoo

  • [x] make Yang and Jensen & Nugent parcel initial parameters common (T, p, RH, ...)
  • [ ] introduce a better error message indicating wrong order of dynamics in builder (condensation vs. ambient thermodynamics)
  • [ ] double check if the concentrations in Table 3 are for STP conditions or other?
  • [ ] more code reuse with other examples (especially G&P 2023 which we have based on)
  • [ ] check why rightmost drop from a sampling range is not included when doing Logarithmic sampling
  • [ ] figure the best tilmestep setting (not given in the paper)
  • [ ] implement and use Bolton SVP formula
  • [ ] implement Grabowski et al. 2011 diffusion kinetics K
  • [x] rename formulae to Grabowski et al. 2011
  • [ ] check where the Grabowski et al. 2011 diffusion thermics formulae where taken from? (and if found, rename)
  • [x] Fig. 4 smoke test
  • [x] Fig. 5 smoke test
  • [x] Fig. 6 smoke test
  • [ ] Fig. 7
  • [ ] Fig. 7 smoke test
  • [ ] Fig. 8
  • [ ] Fig. 8 smoke test
  • [ ] Fig. 9
  • [ ] Fig. 9 smoke test
  • [ ] Fig. 10
  • [ ] Fig. 10 smoke test
  • [ ] move the badges in the README file from condensation-only to condensation-collisions category

bhiogade avatar Feb 15 '24 09:02 bhiogade

@bhiogade, the initial PR, after some code cleanups (README file badges, renaming the formulae to Grabowski et al. 2011), is now merged & released!

slayoo avatar Feb 17 '24 15:02 slayoo

Stale issue message

github-actions[bot] avatar Jul 26 '24 13:07 github-actions[bot]