PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

possible unexpected behaviour for `impl_thrust_rtc/storage.py`

Open TomMelt opened this issue 2 years ago • 2 comments

https://github.com/open-atmos/PySDM/blob/64a54694dad9ee4d817498ec1fc845716ea184cc/PySDM/backends/impl_thrust_rtc/storage.py#L139-L162

I think impl_thrust_rtc/storage.py is possibly not behaving as expected.

For example:

truedivision in python will give int(3)/int(2) == int(1.5)

But I think cuda code uses c/c++ which gives int(3)/int(2) == int(1)

I am in the process of writing tests on a separate fork which I will submit a PR for later today.

TomMelt avatar Jul 14 '23 14:07 TomMelt

Stale issue message

github-actions[bot] avatar Sep 13 '23 13:09 github-actions[bot]

Stale issue message

github-actions[bot] avatar Jan 17 '24 13:01 github-actions[bot]