comparison against trixi via 2d advection

[pawelmagnu]

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.02%. Comparing base (8b7a497) to head (8652686). Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          30       30           
  Lines        1468     1468           
=======================================
  Hits         1351     1351           
  Misses        117      117           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[slayoo]

@pawelmagnu, it seems that the green "passes" of the notebook execution on Windows and macOS are actually silent failures. Adding some print statements results in no output. On macOS, the following is caught on stderr:

_ test_run_notebooks[examples/PyMPDATA_examples/advection_diffusion_2d/advection-diffusion-2d.ipynb] _
----------------------------- Captured stderr call -----------------------------
Assertion failed: false (src/object.cpp:438)

It would be best to replace in the notebook the "!" shell magics with Python subprocess execution including exit status checks to know if actually anything was executed and what was the status code.

[slayoo]

@pawelmagnu, trying the notebook on Colab (https://colab.research.google.com/github/pawelmagnu/PyMPDATA/blob/trixi_comparison/examples/PyMPDATA_examples/trixi_comparison/advection_comparison.ipynb), it fails due to missing Julia binary:

Analogous error will likely happen on mybinder.

Let's try to add a notebook cell with Julia installation magick

[slayoo]

@pawelmagnu it works on Colab now! Kudos!