PyMPDATA icon indicating copy to clipboard operation
PyMPDATA copied to clipboard

new 2D advection diffusion example incl. comparison against Trixi.jl

Open Kojec1 opened this issue 1 year ago • 4 comments

Kojec1 avatar Jun 04 '24 08:06 Kojec1

TODO:

  • [ ] share simulation setting between Trixi.jl and PyMPDATA (e.g., through a common JSON file created in the notebook)
  • [ ] save Julia simulation output to a file
  • [ ] compare simulation output
  • [ ] add Colab/Mybinder badges to the notebook header cell (as in other example notebooks in the repo)

slayoo avatar Jun 04 '24 08:06 slayoo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.02%. Comparing base (efc4440) to head (76532e5). Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          30       30           
  Lines        1468     1468           
=======================================
  Hits         1351     1351           
  Misses        117      117           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 04 '24 10:06 codecov[bot]

@Kojec1 @pawelmagnu the matplotlib version issue is now fixed in the main branch, so I've just rebased this PR's branch accordingly

slayoo avatar Jun 04 '24 16:06 slayoo

kudos @pawelmagnu for making it ✅

slayoo avatar Jul 01 '24 22:07 slayoo

@slayoo examples on windows still time out after 3 re-run, could you help with that?

pawelmagnu avatar Sep 06 '24 19:09 pawelmagnu

@slayoo examples on windows still time out after 3 re-run, could you help with that?

let's see if these will help: #452, #451

slayoo avatar Sep 06 '24 21:09 slayoo

closing & reopening to see if build against current main (with #452 merged) works

slayoo avatar Sep 06 '24 22:09 slayoo