GenAIExamples icon indicating copy to clipboard operation
GenAIExamples copied to clipboard

chatqna ui - nginx proxy_pass

Open SeanCondon opened this issue 1 year ago • 7 comments

Description

This adds a proxy_pass inside the nginx.conf of the chatqna-conversation-ui. This has the effect of avoiding CORS errors when the Javascript in the browser calls the backend service. CORS error occur when the javascript makes a call to a backend host:port not equal to where it was loaded from.

The effect is that the javascript now calls http://host:port/v1/chatqna which the nginx service in the pod will remap to http://chatqna:8888/v1/chatqna inside the cluster.

This was undertaken on the suggestion of @Ruoyu-y in this PR 305 on GenAIInfra

This is an additional fix for #493 and #528

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds new functionality)
  • [ ] Breaking change (fix or feature that would break existing design and interface)
  • [ ] Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Load the services with docker compose according to the instructions in README.md in docker/xeon

SeanCondon avatar Aug 17 '24 17:08 SeanCondon