GenAIExamples icon indicating copy to clipboard operation
GenAIExamples copied to clipboard

Add ChatQnA docker-compose example on AIPC using MariaDB Vector

Open RazvanLiviuVarzaru opened this issue 7 months ago • 10 comments

Description

Add ChatQnA docker-compose example on AIPC using MariaDB Vector. Depends on: https://github.com/opea-project/GenAIComps/pull/1645

Issues

n/a

Type of change

  • [x] New feature (non-breaking change which adds new functionality)

Dependencies

n/a

Tests

Set the HF API token environment variable and:

cd ChatQnA/tests
bash test_compose_mariadb_on_aipc.sh

RazvanLiviuVarzaru avatar May 05 '25 08:05 RazvanLiviuVarzaru

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

github-actions[bot] avatar May 05 '25 08:05 github-actions[bot]

@chensuyue, Is there any AIPC ready for using in CI system?

lvliang-intel avatar May 07 '25 01:05 lvliang-intel

@chensuyue, Is there any AIPC ready for using in CI system?

No, we don't have AIPC for CI.

chensuyue avatar May 07 '25 01:05 chensuyue

We have few test on AIPC, so we don't have specific resource for those test. Unless we plan to implement AIPC test for all the examples, I will try to apply for an AIPC for test. If this test able to run on Xeon as well, I suggest to change the test scripts name into ChatQnA/tests/test_compose_mariadb_on_xeon.sh and the test will be deploy on a xeon machine. And you can add some comments in the beginning of the scripts, reminder us to run this test on AIPC during release test (quarterly).

chensuyue avatar May 07 '25 01:05 chensuyue

We have few test on AIPC, so we don't have specific resource for those test. Unless we plan to implement AIPC test for all the examples, I will try to apply for an AIPC for test. If this test able to run on Xeon as well, I suggest to change the test scripts name into ChatQnA/tests/test_compose_mariadb_on_xeon.sh and the test will be deploy on a xeon machine. And you can add some comments in the beginning of the scripts, reminder us to run this test on AIPC during release test (quarterly).

@chensuyue

I've added a Xeon example here: https://github.com/opea-project/GenAIExamples/pull/1916. For testing, I had to build the dataprep and retriever Docker images myself. I'm not sure if merging https://github.com/opea-project/GenAIComps/pull/1645 should have triggered a push to DockerHub.

As for this PR, feel free to close it, or if you find it valuable, you can merge it once an AIPC runner is available in CI.

Thanks!

RazvanLiviuVarzaru avatar May 07 '25 13:05 RazvanLiviuVarzaru

Labeling this as WIP until we are ready for invest resources into AIPC testing.

ashahba avatar May 07 '25 23:05 ashahba

We have few test on AIPC, so we don't have specific resource for those test. Unless we plan to implement AIPC test for all the examples, I will try to apply for an AIPC for test. If this test able to run on Xeon as well, I suggest to change the test scripts name into ChatQnA/tests/test_compose_mariadb_on_xeon.sh and the test will be deploy on a xeon machine. And you can add some comments in the beginning of the scripts, reminder us to run this test on AIPC during release test (quarterly).

@chensuyue

I've added a Xeon example here: #1916. For testing, I had to build the dataprep and retriever Docker images myself. I'm not sure if merging opea-project/GenAIComps#1645 should have triggered a push to DockerHub.

As for this PR, feel free to close it, or if you find it valuable, you can merge it once an AIPC runner is available in CI.

Thanks!

Once the PR1654 merged, the related images in the dockerhub will be refreshed in one day or two. But in CI test, we always use images build from latest GenAIComps main branch.
Regarding to this PR, you can mark the test with _ as _test_compose_mariadb_on_aipc.sh, so it will not be triggered by CI. And leave a message if you pass the local test and we can merge it first.

chensuyue avatar May 08 '25 03:05 chensuyue

We have few test on AIPC, so we don't have specific resource for those test. Unless we plan to implement AIPC test for all the examples, I will try to apply for an AIPC for test. If this test able to run on Xeon as well, I suggest to change the test scripts name into ChatQnA/tests/test_compose_mariadb_on_xeon.sh and the test will be deploy on a xeon machine. And you can add some comments in the beginning of the scripts, reminder us to run this test on AIPC during release test (quarterly).

@chensuyue I've added a Xeon example here: #1916. For testing, I had to build the dataprep and retriever Docker images myself. I'm not sure if merging opea-project/GenAIComps#1645 should have triggered a push to DockerHub. As for this PR, feel free to close it, or if you find it valuable, you can merge it once an AIPC runner is available in CI. Thanks!

Once the PR1654 merged, the related images in the dockerhub will be refreshed in one day or two. But in CI test, we always use images build from latest GenAIComps main branch. Regarding to this PR, you can mark the test with _ as _test_compose_mariadb_on_aipc.sh, so it will not be triggered by CI. And leave a message if you pass the local test and we can merge it first.

@chensuyue Marked the test script file with _. Tests on my machine were ok, results: https://gist.github.com/RazvanLiviuVarzaru/7dd026dc3ba964bc90331fd45b4c45e7

RazvanLiviuVarzaru avatar May 08 '25 09:05 RazvanLiviuVarzaru

We have few test on AIPC, so we don't have specific resource for those test. Unless we plan to implement AIPC test for all the examples, I will try to apply for an AIPC for test. If this test able to run on Xeon as well, I suggest to change the test scripts name into ChatQnA/tests/test_compose_mariadb_on_xeon.sh and the test will be deploy on a xeon machine. And you can add some comments in the beginning of the scripts, reminder us to run this test on AIPC during release test (quarterly).

@chensuyue

I've added a Xeon example here: #1916. For testing, I had to build the dataprep and retriever Docker images myself. I'm not sure if merging opea-project/GenAIComps#1645 should have triggered a push to DockerHub.

As for this PR, feel free to close it, or if you find it valuable, you can merge it once an AIPC runner is available in CI.

Thanks!

@RazvanLiviuVarzaru

As there is Xeon version example to adopt "MariaDB Vector". For the APIC version, there is no resources for CI/CD for AIPC, how about close this PR?

xiguiw avatar May 16 '25 07:05 xiguiw

We have few test on AIPC, so we don't have specific resource for those test. Unless we plan to implement AIPC test for all the examples, I will try to apply for an AIPC for test. If this test able to run on Xeon as well, I suggest to change the test scripts name into ChatQnA/tests/test_compose_mariadb_on_xeon.sh and the test will be deploy on a xeon machine. And you can add some comments in the beginning of the scripts, reminder us to run this test on AIPC during release test (quarterly).

@chensuyue I've added a Xeon example here: #1916. For testing, I had to build the dataprep and retriever Docker images myself. I'm not sure if merging opea-project/GenAIComps#1645 should have triggered a push to DockerHub. As for this PR, feel free to close it, or if you find it valuable, you can merge it once an AIPC runner is available in CI. Thanks!

@RazvanLiviuVarzaru

As there is Xeon version example to adopt "MariaDB Vector". For the APIC version, there is no resources for CI/CD for AIPC, how about close this PR?

@xiguiw I was hopping that adding _ to avoid triggering the CI + providing my own test results will get this through so users have the chance to test this example on their own laptops / workstations. If that's not possible, yes, you can close it.

RazvanLiviuVarzaru avatar May 16 '25 08:05 RazvanLiviuVarzaru

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

CICD-at-OPEA avatar Jun 15 '25 22:06 CICD-at-OPEA

This PR was closed because it has been stalled for 7 days with no activity.

CICD-at-OPEA avatar Jun 22 '25 22:06 CICD-at-OPEA