log-viewer icon indicating copy to clipboard operation
log-viewer copied to clipboard

Provide stack trace filtering in context

Open essell opened this issue 1 year ago • 4 comments

Filters stack traces in both log text and context since they mostly end up here.

essell avatar May 13 '24 19:05 essell

Tests successful using composer test as well as in dependent Laravel project.

essell avatar May 13 '24 19:05 essell

hey @essell , thanks for the PR!

Do you think we could have a test for this use case? One to make sure a stack trace within a context string gets filtered, and another to make sure non-stack, multiline context strings don't get affected.

arukompas avatar May 17 '24 06:05 arukompas

hey @essell , thanks for the PR!

Do you think we could have a test for this use case? One to make sure a stack trace within a context string gets filtered, and another to make sure non-stack, multiline context strings don't get affected.

@arukompas Sure! FYI, the changes I submitted only look through the first level of the context array for stack trace filtering, and doesn't recurse into it deeper. I suspect that it's a rare use case to stick the trace deep into a sub-array, so I opted for simplicity.

essell avatar May 17 '24 06:05 essell

hey @essell , is this PR still relevant, or have you changed your mind about it?

arukompas avatar Aug 16 '24 11:08 arukompas

Thanks @essell , added the tests here - https://github.com/opcodesio/log-viewer/pull/482

arukompas avatar Oct 18 '25 08:10 arukompas

@essell release tagged - v3.21.0

arukompas avatar Oct 18 '25 10:10 arukompas