Dominik Jain comments

Results 111 comments of


                                            Dominik Jain

Learning rate scheduler confusion

This problem has been eliminated with the introduction of `OptimizerFactory` and `LRSchedulerFactory` in v2.

MPO Implementation

@0x-74, I'd say your plan sounds reasonable.

Suggestion: Custom Collector in the high-level API

Hello @RolandStolz, glad you are enjoying Tianshou! This sounds like a useful addition, though I would suggest the factory pattern, i.e. `with_collector_factory` and a corresponding interface `CollectorFactory`. We are currently...

Suggestion: Custom Collector in the high-level API

@RolandStolz, is `BaseCollector` sufficient as a type bound, i.e. did you derive your custom collectors from it (or one of its subclasses)?

Suggestion: Custom Collector in the high-level API

This is now implemented on branch `dev-v2`.

Suggestion: Custom Collector in the high-level API

This features is now available in the 2.0.0b2 pre-release.

Question about n-step TD in SAC

Sorry for the late response; we have been busy working on Tianshou version 2. No, using a value greater than 1 does not change the fundamental off-policy nature of the...

Bug: JSON-RPC data concatenated to filename, creating corrupted file in project root

@TheJACKedViking I think it's highly unlikely that the file was created by Serena in the regular workflow. Are you sure this is what happened?

Major Performance Decrease in Tianshou 1.2 Compared to 0.5 on Windows and Linux

Since you are running on Windows: Do you have an Nvidia GPU which you expect to be using? If so, please check whether the GPU is indeed being used. Default...

Major Performance Decrease in Tianshou 1.2 Compared to 0.5 on Windows and Linux

I did a quick speed test, comparing 0.5.0 to 1.0.0 and the current development version (1.2.0-dev). I tested with the atari_ppo example, using CPU, the Pong environment and a single...