Olivier Paroz
Olivier Paroz
OK, filed in `core` https://github.com/owncloud/core/issues/14712
A big problem we'll be facing when this is fixed is that all these "bad" pictures will be stored in the cache as `400-200-with-aspect.png` and there is currently no way...
So, I've had a look and for large previews, I've applied a quick fix which should help with most previews
For thumbnails, it's a bit more complicated. We always ask for 400x200 pictures, so it's either - we stretch them to maybe 800x400 and crop them to 800x200, leading to...
_From @jospoortvliet on March 6, 2015 13:17_ Hmm, the crop is probably the best one. That is already wide, and it's less bad than blurry I think...
Let's see if other people want to chime in. It should be possible to fix wide images, but the Preview class doesn't make it easy as there isn't a way...
I've filed this in core to try and make it easier to alter previews quickly if we see that a preview could be problematic: https://github.com/owncloud/core/issues/14739
_From @jospoortvliet on March 6, 2015 23:52_ @oparoz note that in my opinion - this isn't a huge issue. The crop is quite OK. Yes, yes, showing them fully is...
The problem is that it doesn't only affect panoramic pictures. Any picture with a height smaller than 200 will be stretched, so cropping works for pictures, but wouldn't look great...
_From @jospoortvliet on March 7, 2015 19:4_ Ok, I understand. So no easy fix for this one...