opal-browser icon indicating copy to clipboard operation
opal-browser copied to clipboard

Published 20 hours ago • verified publisher icon opal

Add ParentNode and fix children implementation

Open davispuh opened this issue 9 years ago • 1 comments

Look at https://developer.mozilla.org/en-US/docs/Web/API/ParentNode

ParentNode.children returns only element nodes without text nodes unlike Node.childNodes which includes all Nodes and so current implementation is wrong.

Note that I haven't really tested this yet but I think it should work, also there aren't tests for this.

davispuh avatar Sep 29 '15 04:09 davispuh

Regarding the children method, I think this implementation should follow Nokogiri for an expected behaviour.

hmdne avatar Jul 05 '20 19:07 hmdne