opacclient
opacclient copied to clipboard
opacapp
[WIP] JSoup upgrade
@TacoTheDank already tried to upgrade JSoup in #581, but this lead to some test failures in libopac. We need to investigate these and also do some testing of search in different OPAC systems to make sure that we don't introduce bugs with the JSoup upgrade.
Since version 1.11.1, Jsoup replaces " " (" ") characters with spaces. This was the cause of two of the test failures, and will probably also affect some implementations in the other APIs. We should further investigate this.
The test failures should be fixed now, but more testing of the parts of libopac not covered by the automated tests is required (see above).
@raphaelm You updated JSoup in 11833f3234, have you tested if this doesn't break anything? Especially the replacement mentioned above may be important for some of the APIs.
At least the other changes in this PR probably need to be merged to fix the tests.
ouch, sorry, somehow missed this. I think I needed to upgrade to replace the (no longer really working) stetho with flipper for debugging. I'll look into this and downgrade or fix, just need to find the time.
Ah, okay. Regarding Stetho issues: I think a recent Chrome update broke it, also noticed that in https://github.com/johan12345/EVMap. It still works in other Chromium-based browsers though (Microsoft Edge, Brave). These the corresponding Stetho and Chromium issues: https://github.com/facebook/stetho/issues/696, https://bugs.chromium.org/p/chromium/issues/detail?id=1187142