multiline-collapsingtoolbar icon indicating copy to clipboard operation
multiline-collapsingtoolbar copied to clipboard

Published 20 hours ago • verified publisher icon opacapp

Duplicated text for RTL languages

Open VitalikL opened this issue 6 years ago • 3 comments

Addressing #33

This is not the cleanest solution, as it uses specific calculation for the X coordinate when isRTL. Also, it does not address the issue of the animation for RTL

VitalikL avatar Feb 27 '18 06:02 VitalikL

Thank you for your Pull request! I just tested your version using the text that you tested in #33. The expanded state looks good, but as you said, the animation is not really complete and also, the text seems to have a wrong position (too low) in the collapsed state: device-2018-03-01-222949

Would you like to continue to work on this so that we can have one PR that fixes all RTL problems?

johan12345 avatar Mar 01 '18 21:03 johan12345

Thanks @johan12345. It is strange that the text is very low in collapsed state, since the change introduced here is only for horizontal positioning of expanded caption. I will test master version later to see if this is a regression

VitalikL avatar Mar 01 '18 22:03 VitalikL

Hey, we are currently trying to get the multiline feature merged into the official Material Components library (see the PR). However, for that, we need to make the animation work correctly in RTL languages. I tried to fix it, but so far I haven't found out how. Would you be interested in helping us with that?

johan12345 avatar Jul 11 '19 16:07 johan12345