gatsby-source-instagram
gatsby-source-instagram copied to clipboard
Update to be compatible with Gatsby 3
From what I can see, there are no errors thrown after having upgraded the dependencies to be compatible with Gatsby 3. The only thing I had to change was commenting out the hashtags
in /example/pages/index.js
. Revert that change in case your local example setup is different. Also, feel free to adjust this PR as it suits you. Hope this helps also others already running Gatsby 3.
Fixed this warning that relates to this deprecation:
Calling "touchNode" with an object containing the nodeId is deprecated.
Please pass the node directly to the function: touchNode(node)
"touchNode" was called by gatsby-source-instagram
Fixes #188
👷 Deploy request for gatsby-src-instagram accepted.
🔨 Explore the source changes: 791fefdeabf69ba459d8c3ac48afd68469c3c3df
🔍 Inspect the deploy log: https://app.netlify.com/sites/gatsby-src-instagram/deploys/610d8323b5f0760007b5e0c2
Hey thanks for this!!!! I am on holidays till end of next week so i ll be able to release this later. approved the netlify build to see how it works
@oorestisime Looks like Node.js v10 is configured in Netlify, but Gatsby 3.x requires at least v12.
Added node version 12 but still fails (sorry cant check more than that for another week )
I will have another look as soon as I have time myself 😄 Thanks.
Hey i just came back from holidays. Let me know if you want me to take a look as well :)
Hey i just came back from holidays. Let me know if you want me to take a look as well :)
The same for me 😄 Yes please have a look as well. That would help. Thanks in advance.
Any luck with this upgrade? I am using Gatsby 3 and can't install your plugin via npm:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: xxx
npm ERR! Found: [email protected]
npm ERR! node_modules/gatsby-source-filesystem
npm ERR! gatsby-source-filesystem@"^3.1.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer gatsby-source-filesystem@"^2.0.27" from [email protected]
npm ERR! node_modules/gatsby-source-instagram
npm ERR! gatsby-source-instagram@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
I'm getting new errors with Gatsby 4
ERROR #11321 PLUGIN
"gatsby-source-instagram" threw an error while running the
sourceNodes lifecycle:
Cannot read properties of undefined (reading 'type')
133 | if (data) {
134 | return Promise.all(data.map(async datum => {
> 135 | const res = await
normalize.downloadMediaFile({
| ^
136 | datum: processDatum(datum, params),
137 | store,
138 | cache,
File:node_modules/gatsby-source-instagram/gatsby-node.js:135
:19
This pull request is also working for me on Gatsby 4.
After I used yarn add https://github.com/m99coder/gatsby-source-instagram
to pull your branch into my project it built successfully.
Any chance to get it merged and released?
Maybe we can close this in favor of #239