probe icon indicating copy to clipboard operation
probe copied to clipboard

oohttp: add header ordering support

Open fedosgad opened this issue 3 years ago • 2 comments

I have forked oohttp (this is a great library btw, thanks a lot for it!) to add support for features absent in stdlib's http client, such as header ordering (including HTTP2 headers and pseudoheaders), manipulating HTTP2 settings and HTTP2 SERVER PUSH. My intent is to make mimicking "normal" web browsers (Chrome/FF/you name it) simplier and more accurate.

Code is available at github.com/fedosgad/oohttp. Currently, I've finished header ordering (ported from fhttp).

Changes were made in (I hope) maintainable way, similar to what oohttp itself has done (see PATCHING.md). I would like to contribute those changes back to oohttp. What do you think about it?

fedosgad avatar Jun 22 '22 22:06 fedosgad

Absolutely! I'll add to my sprint to take a look at your changes, thank you!

bassosimone avatar Jun 23 '22 08:06 bassosimone

That's great! Feel free to ping me if there are any questions.

fedosgad avatar Jun 23 '22 09:06 fedosgad

I am very much interested in seeing this get rolled in. @bassosimone would it be helpful for me to put together a PR, or is this something you've already started on?

nathanejohnson avatar Sep 05 '23 18:09 nathanejohnson

@nathanejohnson it seems there is already an open PR: https://github.com/ooni/oohttp/pull/46

bassosimone avatar Sep 19 '23 07:09 bassosimone