probe icon indicating copy to clipboard operation
probe copied to clipboard

refactor: unnest and simplify oohelper implementation

Open bassosimone opened this issue 2 years ago • 2 comments

While working on https://github.com/ooni/probe-cli/pull/805, I noticed that oohelper's implementation could really use a cleanup and refactoring. Here's what we should roughly do:

  • [ ] unnest the implementation (long time ago, I was creating many small interconnected packages while now I have settled on creating a large, flat set of packages)
  • [ ] make sure we're using unit tests rather than integration tests
  • [ ] we should use mocks from internal/model/mocks rather than rolling out our own mocks
  • [ ] if we need integration tests, we should be testing against the oohelperd implementation in the same codebase

This refactoring is not very important because the existing code is working ~fine, but would improve the state of the tree.

bassosimone avatar Jun 08 '22 07:06 bassosimone

Turns out we already did this but forgot to close the issue!

bassosimone avatar Aug 28 '22 11:08 bassosimone

My mistake, this is about oohelper and not oohelperd 😢

bassosimone avatar Aug 28 '22 11:08 bassosimone