probe icon indicating copy to clipboard operation
probe copied to clipboard

cli: show automated test results

Open bassosimone opened this issue 3 years ago • 3 comments

Describe the feature request Users would like to see the results of automated runs. Based on private conversations with users, it seems this bug was initially proposed for Linux, but, in general, these (advanced) users will fancy seeing automated tests everywhere.

To Reproduce It is not straightforward to do that. On Linux, You can use sudo OONI_HOME=/var/lib/ooniprobe -u ooniprobe ooniprobe list to read the results. On Windows, it's currently not clear to @bassosimone how that could be done.

Expected behavior The expected behavior would be to also show the results of automated runs.

Screenshots N/A

System information (please complete the following information):

  • Device: N/A
  • OS: Linux, Windows, Android, iOS
  • Version: N/A

Additional context Unfortunately, on Linux the systemd-run ooniprobe runs with the privileges of a different user, so the OONI_HOME is physically in another location. @bassosimone has no idea whether listing runs would be feasible on Windows and how.

bassosimone avatar Sep 06 '21 08:09 bassosimone

On Linux we could add a more user-friendly flag e.g. list-unattended. It could either call sudo by itself or the measurements in /var/lib/ooniprobe could be created with read permissions for every user.

FedericoCeratto avatar Sep 06 '21 10:09 FedericoCeratto

Thanks for taking this into consideration. Just few quick notes:

  1. ooniprobe requires write access to /var/lib/ooniprobe/assets to perform list or show commands. At least on my test system.
  2. If list-unattended flag is decided to be added, users might still need show-unattended. Maybe it would be better to let users to pass OONI_HOME to the command via --home=DIR or similar option.

alimirjamali avatar Sep 06 '21 17:09 alimirjamali

I have written https://github.com/ooni/ooni.org/pull/1217 that should fix the immediate issue by documenting the commands required to see the results. Though, I feel there are two bugs here that are annoying: (1) that ooniprobe needs to write in order to list results; (2) that there is no user friendly way to see those results. As such, I am not sure we should close this issue once https://github.com/ooni/ooni.org/pull/1217 is merged.

bassosimone avatar Aug 29 '22 17:08 bassosimone