probe-desktop icon indicating copy to clipboard operation
probe-desktop copied to clipboard

WIP: Add Continuous Delivery

Open Ceda-EI opened this issue 4 years ago • 3 comments

  • [x] Do Linux Builds
  • [ ] Do Windows Builds
  • [ ] Do MacOS Builds

Example builds were run on the test-ci branch of my fork.

Ceda-EI avatar May 04 '20 19:05 Ceda-EI

The failing CI seems to be unrelated.

Ceda-EI avatar May 06 '20 06:05 Ceda-EI

This is really cool! Thanks for putting it together!

You are right that the CI build on macOS has been causing quite some issues, as a matter of fact I am now going to disable it until we find why it's not working well (see: https://github.com/ooni/probe/issues/1157).

I don't know so much about linux app distribution, so maybe @FedericoCeratto or @sarathms can look at that part and see if it makes sense to integrate this.

WRT the macOS and windows builds, the challenge with doing CD on those is that we would have to give our code signing keys to github, which I think we should first carefully discuss and evaluate the tradeoffs of that approach.

That said, maybe we can just have unsigned developer builds made using this process and keep the "standard" process for signed builds.

This PR relevant to: https://github.com/ooni/probe/issues/1091.

hellais avatar Jun 03 '20 13:06 hellais

I actually raised the concern about the need of signing keys to be uploaded to github in the IRC. On top of that, Github does not have any mechanism for uploading secret files into the build. Github's recommended approach is committing an encrypted version of the key to repo and then adding the password to it as a secret. Source.

Ceda-EI avatar Jun 04 '20 12:06 Ceda-EI