probe-android
probe-android copied to clipboard
ooni
Make it obvious to see all the logs
Fixes https://github.com/ooni/probe/issues/1777
Proposed Changes
- Include log file appender
- Fetch and display logs to UI.
- Add log file sharing.
| . | . | . | . |
|---|---|---|---|
 |
 |
 |
 |
Feature request: possibility of sharing the logs with OONI developers! (We're starting to test this!)
I have updated the user story accordingly: https://github.com/ooni/probe/issues/1777.
We discussed today with @aanorbel that we'll implement sharing of the whole logfile via Telegram, etc.
I have used and testing this functionality a bit. Here's some extra feedback:
-
[ ] I see some utility in sharing logs as HTML, but I would rather share them as a text file without tags because I think ultimately the presence of tags would only make log processing more complex on our end
-
[x] the "advanced" menu entry now seems to contain two "debug logs" entries, however I think the one that leads to the logs should not be named "debug logs" but perhaps something like "see recent logs"
I tested the sharing feature and it's working as intended, thank you!
I am using the diff and I am happy with it. However, I think it would be better if we only selected the "LOG" events and just emitted their severity and content. Currently we're emitting all MK events, which I think only adds confusion.
We can always change the type of events we log. Establishing the necessary framework for logging and sharing logs was top priority. I would be removing logs for MK_EVENTS.
We can always change the type of events we log. Establishing the necessary framework for logging and sharing logs was top priority. I would be removing logs for
MK_EVENTS.
What I suggest is to only log the MK_EVENTS that contain log messages. You can identify them by their key which is log. There should be a place in the codebase where we already trap this event for logging. That should suffice.
Thank you! 🙌