acf-focuspoint icon indicating copy to clipboard operation
acf-focuspoint copied to clipboard

Published 20 hours ago • verified publisher icon ooksanen

Possible improvements of this package

Open hirasso opened this issue 8 months ago • 1 comments

Hi @ooksanen !

As I was implementing the PR #17 , I noticed a few chances for enhancements. I'd be happy to take care of them, as I'm planning on using this package in many (if not all) future projects.

  1. There is a lot of commented out code in https://github.com/ooksanen/acf-focuspoint/blob/master/fields/class-acffp-acf-field-focuspoint-v5.php – Would you agree that this could be removed?
  2. Would you be fine with introducing an .editorconfig so that if other contributors would edit the files, they would not mess with the formatting? I needed to manually "save without formatting" so that you wouldn't be overwhelmed with changes all over the place. As I'm a maintainer of the package swup and have quite some experience with these kinds of things, I could take care of that, too.
  3. I would like it if the focus point couldn't only be set by a click, but if it would be draggable, as well. What do you think about that?

Also, if you are not using this package anymore and don't want to maintain it, I would gladly take it over. We could discuss the "how" in a call if you'd like.

hirasso avatar Jun 24 '24 08:06 hirasso