Kirill Bubochkin

Results 97 comments of Kirill Bubochkin

Well, as for me, `DecoratedBox` without `decoration` looks really weird and could lead to even more non-obvious code. E.g. construction like this would definitely be weird: ```dart DecoratedBox(child: Text('Hello World'))...

> That's essentially what Container does internally as well. But that's the point. This makes the hint suggested by `use_decorated_box`: - not possible to implement in a "straightforward" way –...

If you pass only the decoration, the result would be pretty much the same. Ok, there will be several additional `if`s, but it definitely won't affect performance to worry about...

I care about that difference when it makes sense. `const DecoratedBox(decoration: decoration, child: child)` vs `Container(decoration: decoration, child: child)` makes sense, because `DecoratedBox` has a `const` constructor. `Container(decoration: decoration, child:...

There is a PR #97 for that. It lacks tests, but I didn't have time to work on it since then.

I'm totally ok if someone will finish my PR (or do it from scratch), I won't have time to work on it in the near future, unfortunately.

@justinenerio I've pushed some changes: - Added `active` parameter. I remember we were discussing that it's not required for our specific use case, but it's easy to add and it...

Yes, the problem can be with an unstable connection. There's no auto-reconnect mechanism, but since you receive `Stream`, you can implement some custom reconnection logic on top of it.

Hm, that's interesting. What device are you testing it on?

@moksh-mahajan I would say it should work like this in general: - if you select the source token the same as the destination token, the destination token should be updated...