text-generation-webui icon indicating copy to clipboard operation
text-generation-webui copied to clipboard

Published 20 hours ago • verified publisher icon oobabooga

Fix stopping strings in api

Open karlovm opened this issue 2 years ago • 5 comments

By default, stopping strings is ignored when used in default API. That's simple fix for that.

karlovm avatar Apr 18 '23 16:04 karlovm

Is this why silly tavern keeps generating?

Ph0rk0z avatar Apr 19 '23 13:04 Ph0rk0z

It seems even with this PR I'm seeing the behavior of a stop string being ignored.

Not sure which side has the problem (interface vs API). The bug is being tracked in SillyTavern here: https://github.com/Cohee1207/SillyTavern/issues/76

sinoth avatar Apr 19 '23 20:04 sinoth

For me it fixes the problem, because generate_reply don't process stopping strings with state and my PR fixes that API behavior

karlovm avatar Apr 19 '23 22:04 karlovm

It still doesn't work

CyberTimon avatar Apr 21 '23 09:04 CyberTimon

It's working for me without this PR on sillytavern. Just update the gradio ID to 43.

Ph0rk0z avatar Apr 21 '23 12:04 Ph0rk0z

I think that this is already working after https://github.com/oobabooga/text-generation-webui/pull/990

oobabooga avatar Apr 23 '23 18:04 oobabooga