onyx icon indicating copy to clipboard operation
onyx copied to clipboard

Replace nginx with Caddy

Open markbotterill opened this issue 10 months ago • 1 comments

This PR aims to replace nginx with Caddy. Caddy requires fewer files to operate, is easier to get started with and performs similarly to nginx for most use cases.

The primary query I had about this PR was to do with global variables: In the Caddyfile, Caddy expects to see a domain name (without https:// proceeding it) but the web_server requires the full URL for things like Oauth re-directs. My current solution was the addition of the $DOMAIN variable (which is then used in the $WEB_DOMAIN variable) and this can be found in the env.prod.template but may not be best practice. Very open to feedback :)

Cheers!

markbotterill avatar Apr 10 '24 14:04 markbotterill

@markbotterill is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 10 '24 14:04 vercel[bot]

Hello, sorry for delayed response on this one. Teams are generally more familiar with nginx and it's more performant. To support more teams being able to manage their own nginx and higher scale deployments of Danswer we will be continuing with nginx.

yuhongsun96 avatar Sep 08 '24 01:09 yuhongsun96