newsroom dark mode as default

dark mode as default

Open anibal-aguila opened this issue 3 years ago • 5 comments

Hi, great work! There are some way to have dark mode as default,

Thanks in advance,

Jan 31 '22 20:01 anibal-aguila

Jan 31 '22 21:01 jmooring

@anibal-aguila, this feature doesn't exist currently. Will add soon

Jan 31 '22 21:01 onweru

Hi @onweru I add it, hope it's ok.

https://github.com/onweru/newsroom/pull/44

Please close this issue if you think it's done.

Regards,

Jan 31 '22 22:01 anibal-aguila

RE: #44:

No.

There are two different capabilities to consider:

Setting the default mode to either light or dark, and allow the user to switch between them. The mode must be sticky as the user navigates the site.
Disallow mode switching.

Jan 31 '22 22:01 jmooring

@jmooring is absolutely right. I have implemented it before in the compose theme, so I just need time carry over the same here.

Jan 31 '22 23:01 onweru

I think this is now settled after be27fd3dcca7f338765ebd2bc8abb45d69fc13c4. The change is of course backward compatible.

Jan 05 '23 17:01 onweru