graphql-pundit icon indicating copy to clipboard operation
graphql-pundit copied to clipboard

Add alias resolve for resolve_field method

Open durcak opened this issue 5 years ago • 4 comments

Compatibility for new GraphQL::Execution::Interpreter, because the interpreter calls a different method: #resolve(obj, args, ctx), instead of #resolve_field(obj, args, ctx).

durcak avatar Sep 11 '19 17:09 durcak

This need more changes, than I thought 👎

durcak avatar Sep 11 '19 18:09 durcak

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         785    794    +9     
=====================================
+ Hits          785    794    +9
Impacted Files Coverage Δ
lib/graphql-pundit/scope.rb 100% <100%> (ø) :arrow_up:
spec/graphql-pundit/authorization_spec.rb 100% <100%> (ø) :arrow_up:
spec/graphql-pundit/scope_spec.rb 100% <100%> (ø) :arrow_up:
lib/graphql-pundit/authorization.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5961fb...dead7be. Read the comment docs.

codecov-io avatar Sep 11 '19 18:09 codecov-io

Test are probably failing because of bug refered in issue 53

durcak avatar Sep 12 '19 07:09 durcak

@phyrog Hi can you look at this? There is new release of graphql gem 1.10.0 with new interpreter as default. Thanks.

durcak avatar Jan 22 '20 09:01 durcak