robot icon indicating copy to clipboard operation
robot copied to clipboard

ROBOT reduce does not reduce subclasses between names by default

Open matentzn opened this issue 3 years ago • 3 comments

Currently:

robot reduce -i o.ofn  -o reduced.ofn

Does not reduce A = B, A Sub B , B Sub A to A = B (where A and B are names).

Only this does:

robot reduce -i o.ofn --named-classes-only true -o reduced.ofn

@cmungall if this is intended, we should clarify this in the docs

matentzn avatar Dec 17 '21 20:12 matentzn

The docs are indeed confusing here:

Reciprocal subclass axioms (e.g. A SubClassOf B, B SubClassOf A), entailing equivalence between A and B, may be removed by reduce. In this case it is important to assert an equivalence axiom (A EquivalentTo B) using the reason command before running reduce.

The "may" here is not helpful, as is the asymmetry between the two algorithms (NC only vs anonymous).

Leave this assigned to me and I will fix. There are some java docstrings that could be elevated up to the markdown.

Note there is a more detailed treatment of redundancy/transitive reduction here: https://github.com/balhoff/relation-graph/issues/63

cmungall avatar Dec 20 '21 17:12 cmungall

I think this is resolved now?

cmungall avatar Apr 19 '24 15:04 cmungall

I am not sure at all! I have not fixed this issue if it existed!

matentzn avatar Apr 19 '24 15:04 matentzn