robot icon indicating copy to clipboard operation
robot copied to clipboard
verified publisher icon ontodev

Multi annotation column

Open pk-mitre opened this issue 1 year ago • 2 comments

Resolves [#ISSUE, resolves #ISSUE]

  • [ ] docs/ have been added/updated
  • [ ] tests have been added/updated
  • [ ] mvn verify says all tests pass
  • [ ] mvn site says all JavaDocs correct
  • [ ] CHANGELOG.md has been updated

[DESCRIPTION, mentioning relevant #ISSUE]

pk-mitre avatar Jun 19 '24 19:06 pk-mitre

The PR looks good. I'm a bit hesitant about this feature, because I don't see the benefit of using a single column over multiple columns. Can you describe your use case? Is it that your single AP column might contain many different annotation properties?

jamesaoverton avatar Jun 24 '24 15:06 jamesaoverton

I'm still having trouble seeing the use case for this, but I'm not opposed to it. Can you please complete the documentation for this feature in template.md?

jamesaoverton avatar Jul 30 '24 14:07 jamesaoverton

I'd like to see this capability added. We use dozens of annotation properties for curation and domain specific descriptions but an individual term is likely to use only a small number (but necessarily the same ones in a batch). Putting both the property and literal into a single pipe-separated field keeps us from maintaining very wide but sparse spreadsheets and we don't have to change the template when we add new annotation properties.

dlutz2 avatar Jan 19 '25 22:01 dlutz2

Thanks @dlutz2. Have you used or tested this PR?

jamesaoverton avatar Jan 23 '25 19:01 jamesaoverton

We've been using the multi-annotation capability in production since it was proposed. Been working fine.

dlutz2 avatar Jan 23 '25 21:01 dlutz2

I made some changes and generalizations to this in #1249 Please take a look.

jamesaoverton avatar Mar 07 '25 17:03 jamesaoverton