onsip
[H.264] SDP Modifiers Not Triggered When Configuring sessionDescriptionHandlerFactoryOptions in SIP.js 0.21.2
Labels: bug h264 sdp
Environment SIP.js Version: 0.21.2 Browser: Chrome 133 WebRTC Server: FreeSWITCH 1.10
Issue Description When attempting to force H.264 video codec by modifying SDP through sessionDescriptionHandlerFactoryOptions.modifiers, the modifier function is not invoked. The modifiers array remains empty during SessionDescriptionHandler initialization despite explicit configuration.
Steps to Reproduce 1: Configure UserAgent with sessionDescriptionHandlerFactoryOptions:
const userAgent = new SIP.UserAgent({ loggerFactory: { /* ... */ }, sessionDescriptionHandlerFactoryOptions: { modifiers: [forceH264] // Modifier not triggered } });
2: Initiate a video call with constraints:
userAgent.invite(target, { sessionDescriptionHandlerOptions: { constraints: { audio: true, video: true } } }); Observe that forceH264 function is never called.
Expected Behavior The forceH264 modifier should process SDP to retain only H.264 payloads. Resulting SDP should contain a=rtpmap:... H264/90000 and exclude other codecs like VP8/VP9.
Current Behavior modifiers array is empty in SessionDescriptionHandler options (debug screenshot). Raw SDP still contains multiple video codec options (e.g., VP8).
Dear SipJs API User,
This is to inform you that our team no longer actively manages or supports the SipJs API. As a result, we cannot provide development support, address issues, or implement changes.
We would recommend that you review the existing documentation or explore alternative solutions to meet your needs.
We apologize for any inconvenience and appreciate your understanding.
Best regards, SipJs API Team
From: changshenglong @.> Date: Friday, February 28, 2025 at 1:38 AM To: onsip/SIP.js @.> Cc: Subscribed @.***> Subject: [onsip/SIP.js] [H.264] SDP Modifiers Not Triggered When Configuring sessionDescriptionHandlerFactoryOptions in SIP.js 0.21.2 (Issue #1103) CAUTION: This email is originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Labels: bug h264 sdp
Environment SIP.js Version: 0.21.2 Browser: Chrome 133 WebRTC Server: FreeSWITCH 1.10
Issue Description When attempting to force H.264 video codec by modifying SDP through sessionDescriptionHandlerFactoryOptions.modifiers, the modifier function is not invoked. The modifiers array remains empty during SessionDescriptionHandler initialization despite explicit configuration.
Steps to Reproduce 1: Configure UserAgent with sessionDescriptionHandlerFactoryOptions:
const userAgent = new SIP.UserAgent({ loggerFactory: { /* ... */ }, sessionDescriptionHandlerFactoryOptions: { modifiers: [forceH264] // Modifier not triggered } });
2: Initiate a video call with constraints:
userAgent.invite(target, { sessionDescriptionHandlerOptions: { constraints: { audio: true, video: true } } }); Observe that forceH264 function is never called.
Expected Behavior The forceH264 modifier should process SDP to retain only H.264 payloads. Resulting SDP should contain a=rtpmap:... H264/90000 and exclude other codecs like VP8/VP9.
Current Behavior modifiers array is empty in SessionDescriptionHandler options (debug screenshot). Raw SDP still contains multiple video codec options (e.g., VP8).
— Reply to this email directly, view it on GitHubhttps://github.com/onsip/SIP.js/issues/1103, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAECG7HFRU4WNALLEDKCD2D2R774PAVCNFSM6AAAAABYBSI33GVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA4DMMZTGYYTENY. You are receiving this because you are subscribed to this thread.Message ID: @.***> [changshenglong]changshenglong created an issue (onsip/SIP.js#1103)https://github.com/onsip/SIP.js/issues/1103
Labels: bug h264 sdp
Environment SIP.js Version: 0.21.2 Browser: Chrome 133 WebRTC Server: FreeSWITCH 1.10
Issue Description When attempting to force H.264 video codec by modifying SDP through sessionDescriptionHandlerFactoryOptions.modifiers, the modifier function is not invoked. The modifiers array remains empty during SessionDescriptionHandler initialization despite explicit configuration.
Steps to Reproduce 1: Configure UserAgent with sessionDescriptionHandlerFactoryOptions:
const userAgent = new SIP.UserAgent({ loggerFactory: { /* ... */ }, sessionDescriptionHandlerFactoryOptions: { modifiers: [forceH264] // Modifier not triggered } });
2: Initiate a video call with constraints:
userAgent.invite(target, { sessionDescriptionHandlerOptions: { constraints: { audio: true, video: true } } }); Observe that forceH264 function is never called.
Expected Behavior The forceH264 modifier should process SDP to retain only H.264 payloads. Resulting SDP should contain a=rtpmap:... H264/90000 and exclude other codecs like VP8/VP9.
Current Behavior modifiers array is empty in SessionDescriptionHandler options (debug screenshot). Raw SDP still contains multiple video codec options (e.g., VP8).
— Reply to this email directly, view it on GitHubhttps://github.com/onsip/SIP.js/issues/1103, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAECG7HFRU4WNALLEDKCD2D2R774PAVCNFSM6AAAAABYBSI33GVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA4DMMZTGYYTENY. You are receiving this because you are subscribed to this thread.Message ID: @.***>
Project is dying. Latest release 2 years ago and now these notice. Please put on your homepage and in github home readme.md that project is on hiatus or will discontinued, in respect to users.
@changshenglong I don't see any documentation that indicates you can pass modifiers to the SDH options like that. Can you point me to the documentation or tutorial you're following?
