ginkgo
ginkgo copied to clipboard
Can't set custom GracePeriod on uninterruptible clean up node
Scenario:
- Tests timeout after global timeout of 1h
-
ReportAfterSuite
is run - If the
!report.SuiteSucceeded
reporting mechanism needs to first collect diagnostics ( which is a long running task, ~5min ) - Grace period timeout occurs
I tried setting GracePeriod for ReportAfterSuite but I'm getting:
[ReportAfterSuite] was passed NodeTimeout, SpecTimeout, or GracePeriod but
does not have a callback that accepts a SpecContext or context.Context. You
must accept a context to enable timeouts and grace periods
It seems also that there is no way to pass Context
to ReportAfterSuite
so it's uninterruptable and I can't set custom GracePeriod.
Any suggestions on how to fix this?
Update: I created a draft PR #1345
hey thanks for the PR - I left some comments over there.
fixed in #1345