ginkgo icon indicating copy to clipboard operation
ginkgo copied to clipboard

change interface{} to any and update to go 1.20

Open ehsandavari opened this issue 2 years ago • 2 comments

ehsandavari avatar May 19 '23 13:05 ehsandavari

I think this is the right direction, but there is an issue around timing. Go 1.19 is still in support, and many folks are on older versions. Although Ginkgo only supports the Go versions in support, in the past we have tried not to break folks who are a little out of date where the cost of doing that is low.

  • any was introduced in Go 1.18, so my personal opinion is that it would be ok to merge this part
  • As Go 1.19 is still in support, I'd suggest that the update to Go 1.20 is not merged at this stage because it would break some people and doesn't introduce any advantage. Eventually we will need this, but I don't think we need it yet.

But these are my personal opinions, and @onsi is the maintainer of this project.

blgm avatar May 23 '23 18:05 blgm

hey @ehsandavari thanks for this - I agree with @blgm

dropping interface{} for any makes sense and the timing is right. We should hold off on any changes that require 1.20 until 1.19 is out of support.

onsi avatar May 28 '23 02:05 onsi