onnxmltools icon indicating copy to clipboard operation
onnxmltools copied to clipboard

Remove use of auto_pad in convert_keras and convert_coreml

Open another-pjohnson opened this issue 5 years ago • 2 comments

Given that auto_pad is deprecated in ONNX and isn't supported for things like infer_shapes, I propose that we remove auto_pad from coreml and keras operator converters (Pool/Conv) and instead use explicit padding.

I was thinking about implementing it. Does anyone have any issues with this?

another-pjohnson avatar Oct 10 '18 18:10 another-pjohnson

Since the keras has output shape, it's doable to calculate the actual padding size. And there is one reminder that onnxmltools needs to generate multiple version onnx model, e.g. any change must make sure the backward compatibility.

wenbingl avatar Oct 10 '18 21:10 wenbingl

@pjohnson-wave I'm quite interested in this matter. Would you like to tell me how to modify the code?

stakemura avatar Jul 25 '19 17:07 stakemura