onnx-mxnet icon indicating copy to clipboard operation
onnx-mxnet copied to clipboard

ONNX Operator "Gather" is not implemented by onnx_mxnet

Open HeliWang opened this issue 7 years ago • 2 comments

In https://github.com/onnx/onnx-mxnet/blob/0ca9a87088619499c932a78cc2871a14b87ab20d/onnx_mxnet/import_helper.py, "Gather" operator is commented. Any idea of solution when the ONNX graph uses “Gather” operator? Thanks

HeliWang avatar Feb 19 '18 00:02 HeliWang

ONNX's "Gather" operator can be mapped directly to MXNet's "take" operator. Exception: Currently, "take" only supports axis 0.

You are welcome to contribute. You can do so by adding a mapping here: https://github.com/onnx/onnx-mxnet/blob/master/onnx_mxnet/import_helper.py#L217 Or I will add a fix soon.

Roshrini avatar Feb 19 '18 21:02 Roshrini

Pull request has been made: https://github.com/spidyDev/incubator-mxnet/pull/1 @spidyDev @Roshrini could you help to have a look? Thanks.

HeliWang avatar Mar 18 '18 18:03 HeliWang