onnx-mlir icon indicating copy to clipboard operation
onnx-mlir copied to clipboard

Published 20 hours ago • verified publisher icon onnx

Next Ops to work on

Open AlexandreEichenberger opened this issue 3 years ago • 22 comments

Idea: put here a quick comment to claim the operations that you care currently working on, so that we do not replicate work. Can also add a request for new op.

AlexandreEichenberger avatar Oct 18 '21 18:10 AlexandreEichenberger

Working on compress

AlexandreEichenberger avatar Oct 18 '21 18:10 AlexandreEichenberger

Working on NonMaxSuppression

tungld avatar Oct 19 '21 09:10 tungld

I am working on SpaceToDepth (#926) and DepthToSpace (#927).

etiotto avatar Oct 19 '21 14:10 etiotto

FYI, here are some of the benchmarks we are focusing on and that have ops that are not working yet.

high priority: (from model zoo)

  • Roberta,
  • Bertsquad (onehot),
  • Bidaf (‘compress’, [edit: now worked on] ‘hardmax’, ‘categorymapper’ [edit: now worked on] ),
  • yolo3 nonmaxsuppression [edit: now worked on]
  • tigny-yolo3: ‘round’[edit: now supported], ‘nonmaxsuppression’ [edit: now worked on]

high priority: support compile models compiled to their lowest component (like RNNs not exported as high level ONNX ops). No crash.

medium prio: hugging face GBERTQnA

A list of ops currently not supported and present in Model Zoo are listed at the end of this issue #128

AlexandreEichenberger avatar Oct 20 '21 14:10 AlexandreEichenberger

I am going to look at categorymapper (#941).

etiotto avatar Oct 21 '21 15:10 etiotto

working on one hot to work with multiple types

AlexandreEichenberger avatar Oct 25 '21 22:10 AlexandreEichenberger

working on Hardmax to support Bidaf. PR #950 (merged).

tungld avatar Oct 26 '21 01:10 tungld

working on Resize.

chentong319 avatar Nov 01 '21 14:11 chentong319

Working on IsNaN op

mmoldawsky avatar Apr 11 '22 20:04 mmoldawsky

Working on ScatterElements (needed by fasterrcnn-10.onnx, maskrcnn-10.onnx). PR is https://github.com/onnx/onnx-mlir/pull/1352

Scatter is deprecated but we map it to ScatterElements. PR is https://github.com/onnx/onnx-mlir/pull/1337

etiotto avatar Apr 14 '22 21:04 etiotto

Working on ScatterND. PR is https://github.com/onnx/onnx-mlir/pull/1370

etiotto avatar Apr 20 '22 15:04 etiotto

Implemented GatherElements. PR is https://github.com/onnx/onnx-mlir/pull/1375.

etiotto avatar Apr 27 '22 15:04 etiotto

Working on GahterND. PR is https://github.com/onnx/onnx-mlir/pull/1382.

etiotto avatar Apr 27 '22 15:04 etiotto

Status of implemented ops are listed here now: https://github.com/onnx/onnx-mlir/blob/main/docs/SupportedONNXOps-cpu.md

AlexandreEichenberger avatar Jul 15 '22 19:07 AlexandreEichenberger

Hi, thank you for your excellent work! I am quite new to MLIR so the questions may be stupid, please never mind. I see ArgMax is supported in onnx-mlir but ArgMin not, is there any special issue for ArgMin? If not, can I open a PR about ArgMin just based on ArgMax with little modification?

airMeng avatar Sep 23 '22 08:09 airMeng

@airMeng please go ahead with a PR for ArgMin. Thank you!

tungld avatar Sep 26 '22 00:09 tungld

Hi, can I work on celu op ?

Ris-Bali avatar Dec 28 '22 16:12 Ris-Bali

Somebody please support QuantizeLinear/DequantizeLinear ops for quantized networks.

muzafferkal avatar Jan 18 '23 03:01 muzafferkal