LLVM (& MHLO) updates in onnx-mlir: Call for volunteers

[sstamenova]

Based on the discussion in the past couple of community meetings, I've added a schedule and instructions for the llvm updates in onnx-mlir:

https://github.com/onnx/onnx-mlir/wiki/LLVM-Update-Schedule

If you are able to contribute, please either add yourself to the schedule (assuming you have permissions) or comment here, so that you can be added.

[christopherbate]

Hi, please add me. I just got the OK to contribute upstream from my employer. I haven't attended community meetings, but I will join the next one. Thanks!

[AlexandreEichenberger]

Wonderful, I believe you should be able to add your name on the wiki page above. Please let me know if that were not the case, still learning about what permission is associated with which roles.

[christopherbate]

@NathanielMcVicar is listed for 1-23-2023, but I did a lot of this work recently. I posted what I have here https://github.com/onnx/onnx-mlir/pull/1977. Happy to exchange places if work hasn't started or hand off what I have., just let me know. Thanks.

@AlexandreEichenberger I can't seem to edit the page.

[NathanielMcVicar]

Hi @christopherbate, I wasn't near as far along as you are with this so why don't you continue with this week, and I can put myself on the end of the schedule (or swap with @sstamenova if she prefers). If I can be of any assistance for this one, please let me know since it looks like you are doing me quite the favor :)

[AlexandreEichenberger]

@AlexandreEichenberger I can't seem to edit the page.

Enabled editing of wiki page for a larger group of users. Will revert if it becomes a problem, which I don't anticipate.

[ashay]

Thanks all for volunteering the LLVM updates! I'll tag the relevant folks here, but let me know if y'all would like me to do that in some other issue.

Week of 02/06/2023:

Green LLVM commit: ba8b8a73fcb6b830e63cd8e20c6e13b2a14d69bf Green MHLO commit: d5a2c51fd78cca9dd91611137cc3d3e89ddf6aa9 (branch: greencommit/2023-02-06-ba8b8a73)

cc: @sstamenova

[ashay]

Week of 02/20/2023:

Green LLVM commit: 5e111eb275eee3bec1123b4b85606328017e5ee5 Green MHLO commit: a99159c45ee5c497f8dce01eff807a6d57629b61 (branch greencommit/2023-02-20-5e111eb2)

cc: @mikeessen

[ashay]

Week of 03/06/2023:

Green LLVM commit: 21f4b84c456b471cc52016cf360e14d45f7f2960 Green MHLO commit: b1ac0403ee2a40fc648ada6b9f11096f3d50fd19 (branch greencommit/2023-03-06-21f4b84c)

[ashay]

Week of 03/20/2023:

Green LLVM commit: 029313cc979ae71877b65794b1063d4e51184cc8 Green MHLO commit: 0045830508ff7be4f99f7130400339ac88fbc829 (branch greencommit/2023-03-20-029313cc)

cc: @gargaroff

[ashay]

Week of 04/03/2023:

Green LLVM commit: 76c83b3595a534c5b28bd80039e2115358ba2291 Green MHLO commit: 57687a58349fa6b64eb9c75a07df67d606c63a9e (branch greencommit/2023-04-03-76c83b35)

cc: @philass

[hamptonm1]

@ashay Do you happen to know the green commit for LLVM and MHLO for this week? Thanks!

[ashay]

Hi @hamptonm1, there's an upstream build error on Windows that I'm trying to resolve (https://reviews.llvm.org/D148541), but once that's merged, I will post the green commits for this week. I'm hoping that I won't run into more errors, but if I do, I'll keep you posted.

[hamptonm1]

Hi @hamptonm1, there's an upstream build error on Windows that I'm trying to resolve (https://reviews.llvm.org/D148541), but once that's merged, I will post the green commits for this week. I'm hoping that I won't run into more errors, but if I do, I'll keep you posted.

Thanks so much!

[ashay]

Week of 04/17/2023:

Green LLVM commit: 3abae1c88416858cf2e9a7ed9417bc52033933b4 Green MHLO commit: 70ebc73a28767b772e09e0dd03cf3e47457435a2 (branch greencommit/2023-04-17-3abae1c8)

cc: @hamptonm1

[ashay]

Week of 05/01/2023:

Green LLVM commit: 6875424135312aeb26ab8e0358ba7f9e6e80e741 Green MHLO commit: 92fd33a4bacbeb93ab276a49f38bdebd5f9d7487 (branch greencommit/2023-05-01-68754241)

cc: @gargaroff

[sorenlassen]

@gargaroff I happened to notice this MLIR change: https://reviews.llvm.org/D148492 which will require some calls to ElementsAttr::getType() to change to getShapedType()

I've touched a lot of the onnx-mlir source code that makes these calls, let me know if you need a hand sorting through the fallout

[ashay]

Week of 05/15/2023:

Green LLVM commit: d421f5226048e4a5d88aab157d0f4d434c43f208 Green MHLO commit: 79a66f9d3169db39cf66d1be045280e02c3951f1 (branch greencommit/2023-05-15-d421f522)

cc: @chenchongsong

[ashay]

Week of 05/29/2023:

Green LLVM commit: 6cf7fe4a9a715bcdf3f4913753109e22dfc9940b Green MHLO commit: a4ac6990f7519a569a380452d7c1d3764aad7e59 (branch greencommit/2023-05-29-6cf7fe4a)

The rotation schedule page doesn't explicitly mention a person for this week. @philass, do you know if the proposed schedule was discussed? If so, is there anyone from Groq who is volunteering to do the LLVM merge this week?

[philass]

@ashay I don't think it has been discussed. But I can bring it up in the onnx-mlir meeting today.

I can take this one on.

[ashay]

Week of 06/12/2023:

Green LLVM commit: bbeda83090adcb3609f9c1331b2345e7fa547f90 Green MHLO commit: 5726753ea0c80f7184da36195b66b7f3e533ef8e (branch greencommit/2023-06-12-bbeda830)

[ashay]

Week of 06/26/2023:

Green LLVM commit: ec89cb9a81529fd41fb37b8e62203a2e9f23bd54 Green MHLO commit: cd47c8c4db420181551e79c42fac22aecc4c06af (branch greencommit/2023-06-26-ec89cb9a)

[ashay]

Week of 07/10/2023:

Green LLVM commit: 8b76aea8d8b1b71f6220bc2845abc749f18a19b7 Green MHLO commit: cae5349f85b3b2f58d80ca788e9a8695d896c3a8 (branch greencommit/2023-07-11-8b76aea8)

cc: @flemairen6

[ashay]

Week of 07/24/2023:

Green LLVM commit: 438fc2c83b73e66f6dbae4f34e9a19f41302f825 Green MHLO commit: 2240bd4c1ed420e91613d5d623414b65ddbba7bf (branch greencommit/2023-07-24-438fc2c8)

cc: @mikeessen

[ashay]

Week of 08/07/2023:

Green LLVM commit: f580901d5d30e37755212f1c09e5b587587fbfeb Green MHLO commit: 503736d156c25022813c51cbdbe3b862d67a6916 (branch greencommit/2023-08-07-f580901d)

[ashay]

Week of 08/21/2023:

Green LLVM commit: 91088978d712cd7b33610c59f69d87d5a39e3113 Green MHLO commit: 01402e75f8e8a95aa2cd9c267ce929095a2f2e54 (branch greencommit/2023-08-21-91088978)

[ashay]

Week of 09/04/2023:

Green LLVM commit: 6098d7d5f6533edb1b873107ddc1acde23b9235b Green MHLO commit: 5a4c066815ba4358919ced9539e899dfd8dee287 (branch greencommit/2023-09-04-6098d7d5)

cc: @jcwchen

[flemairen6]

This week is supposed to be AMD's turn. After discussing with @maxbartel I was looking at this PR https://github.com/llvm/torch-mlir/pull/2466 for llvm's commit. From what I could read, MHLO's repository is being deprecated and torch-mlir has removed their dependency to it in favor of stablehlo. They also haven't had a greencommit for this llvm commit. Should we still be bumping it or are there plan to switch to stablehlo too?

[maxbartel]

@flemairen6 Sorry that information didn't reach you. MHLO will be deprecated if no one steps up to maintain it. If it is just a small bump, maybe include it. If it is a bigger change I think it would be best to open an issue to ask for maintainers and hide the build of it behind cmake flags or similar.

[flemairen6]

No problem, I had assumed that's how it was.

If it is just a small bump, maybe include it

What do you mean by "it"? Otherwise, from what I could gather, and since LLVM had been bumped more recently than usual, the bump doesn't seem to be too big.

[stellaraccident]

Just for information, we are revamping the LLVM integrate process for IREE, which also depends on torch-mlir. We often aim to be within ~24 hours of head so may sometimes end up being the furthest ahead. FWIW - we also test on Windows and MacOS, sometimes carrying transitory patches to fix them while fixes land upstream.

If anyone is looking for a source of green commits and integrate patches for these common deps, happy to coordinate.