onnx-mlir
onnx-mlir copied to clipboard
onnx
Update LLVM/MHLO to for week of 10/10
Green LLVM commit: 438e59182b0c2e44c263f5bacc1add0e514354f8 Green MHLO commit: e6f3ec05c679e86c0a922d1c24ef488d99dfd8aa
The default type for MLIR class accessors was changed, and so I have updated to use kEmitAccessorPrefix_Raw. In the future we can move to use kEmitAccessorPrefix_Prefixed, but that requires a major refactoring which seemed out of scope for this.
Fixed issue where mhlo was giving compile errors for warnings.
Handle Arithmetic dialect renamed to Arith.
Removed assert about attribute count that is no longer valid due to new default attributes.
Use LLVM getLibrary API instead of getPermanentLibrary for ExecutionSessions.
Fix baselines that were wrong due to new attributes and change in alloc variable naming.
Unfortunately, I think we need LLVM change or to remove use of LLVM's DynamicLibrary management code/load libraries ourselves to be able to merge, because LLVM has made it so DynamicLibraries don't get unloaded on llvm_shutdown, which causes issues when we are recompiling libraries with the same name but different dimensions, etc. I have workaround to avoid name collision in the numerical tests, but I don't think that same thing is going to work for the backend tests.
I will try to get this into LLVM to allow unloading DynamicLibraries, but if they don't want it, we will unfortunately need to reimplement their functionality.
Converted to draft as there seems to be some additional work needed to make it work.
I have made this LLVM PR which once merged should unblock us. https://reviews.llvm.org/D134763
Is there any progress on this or at least plans on when the next bump will be attempted?
@gargaroff Yes, I’m currently working on updating the PR now that this week’s green commit contains my upstream change. Working on updating baselines now and hoping to have it ready today.
