models icon indicating copy to clipboard operation
models copied to clipboard

ShuffleNet Model does not have valid onnx names

Open yskim1501 opened this issue 7 years ago • 7 comments

According to documentation all names within a graph must "adhere to C identifier syntax rules." But it looks like ShuffleNet model has input and outputs that are not following this rule(gpu_0/data_0 and gpu_0/softMax_1).

yskim1501 avatar Jun 28 '18 00:06 yskim1501

@houseroad can you help update the model to conform to the spec

prasanthpul avatar Jul 01 '18 17:07 prasanthpul

@prasanthpul yes, this is an issue. We did use names such as "gpu_0/data_0"

houseroad avatar Jul 05 '18 23:07 houseroad

@houseroad thanks for confirming. please let us know when the model might be updated.

@linkerzhang @bddppq we should update the ONNX checker to capture all spec aspects.

prasanthpul avatar Jul 05 '18 23:07 prasanthpul

Do we have any update on this? I verified that same issues applies on the following models as well.

bvlc_reference_rcnn_ilsvrc13.onnx resnet50.onnx zfnet512.onnx

yskim1501 avatar Jul 18 '18 16:07 yskim1501

@houseroad would you help to fix the variable name issue for models that @youngkim93 mentioned above please? Thank you!

linkerzhang avatar Jul 24 '18 23:07 linkerzhang

@linerzhang let me right a script to convert the name

houseroad avatar Jul 24 '18 23:07 houseroad

@houseroad Just wanted to see if a script was created to convert names?

surfertas avatar May 11 '20 11:05 surfertas