models icon indicating copy to clipboard operation
models copied to clipboard

Resnet50-v1-12* models and shufflenet-v1-12* models aren't appropriately included for LFS handling

Open messerb5467 opened this issue 2 years ago • 2 comments

Bug Report

Which model does this pertain to?

The models shown in the below clone:

(base) bmesser:~$ git clone --depth 1 https://github.com/onnx/models.git
Cloning into 'models'...
remote: Enumerating objects: 498, done.
remote: Counting objects: 100% (498/498), done.
remote: Compressing objects: 100% (475/475), done.
remote: Total 498 (delta 20), reused 400 (delta 15), pack-reused 0
Receiving objects: 100% (498/498), 256.58 MiB | 18.33 MiB/s, done.
Resolving deltas: 100% (20/20), done.
Updating files: 100% (400/400), done.
Encountered 8 file(s) that should have been pointers, but weren't:
        vision/classification/resnet/model/resnet50-v1-12-int8.onnx
        vision/classification/resnet/model/resnet50-v1-12-int8.tar.gz
        vision/classification/resnet/model/resnet50-v1-12.onnx
        vision/classification/resnet/model/resnet50-v1-12.tar.gz
        vision/classification/shufflenet/model/shufflenet-v2-12-int8.onnx
        vision/classification/shufflenet/model/shufflenet-v2-12-int8.tar.gz
        vision/classification/shufflenet/model/shufflenet-v2-12.onnx
        vision/classification/shufflenet/model/shufflenet-v2-12.tar.gz

Describe the bug

Instead of being properly included inside the git lfs, these models are coming down as part of the git clone itself.

Reproduction instructions

System Information

This happens on a RHEL 8.4 LoZ server and a Ubuntu 20.04 WSL2 instance. The git clone shown above should be sufficient to recreate the handling.

Notes

No additional notes needed at this time. My plan is to come back through and clean this up myself. It should be a simple adjustment.

messerb5467 avatar Nov 11 '21 19:11 messerb5467

#476, #460, and #442 might be of interest to some people and I'd also like to understand any testing that should be run before simply making those updates.

messerb5467 avatar Nov 11 '21 19:11 messerb5467

I can come through and clean this up as time allows though.

messerb5467 avatar Nov 11 '21 19:11 messerb5467